[Fix-16617][Seatunnel] Use master option for engine deploy mode#18315
Open
JinRudy wants to merge 1 commit into
Open
[Fix-16617][Seatunnel] Use master option for engine deploy mode#18315JinRudy wants to merge 1 commit into
JinRudy wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
added
first time contributor
SbloodyS
requested changes
Jun 5, 2026
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Please using english in commit messages.
| public List<String> buildOptions() throws Exception { | ||
| List<String> args = super.buildOptions(); | ||
| args.add(DEPLOY_MODE_OPTIONS); | ||
| args.add("--deploy-mode"); |
Member
There was a problem hiding this comment.
Please remove the related tests.
Author
There was a problem hiding this comment.
Updated, thanks. I removed the test change and rewrote the branch with a single English commit.
Author
There was a problem hiding this comment.
Updated. I reverted the Spark/constant cleanup and kept this scoped to the SeaTunnel engine path; the PR now changes only SeatunnelEngineTask.
|
JinRudy
force-pushed
the
fix/seatunnel-master-option
branch
from
4152d48 to
adbc2d8
Compare
JinRudy
force-pushed
the
fix/seatunnel-master-option
branch
from
adbc2d8 to
3b89bd5
Compare
JinRudy
force-pushed
the
fix/seatunnel-master-option
branch
from
3b89bd5 to
634a73f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. OpenAI Codex assisted with the change and verification.
Purpose of the pull request
Close #16617.
SeaTunnel 2.3.7 still uses
--deploy-modefor the Spark and Flink starters. The deprecation warning reported in the issue comes from theseatunnel.shclient path, where-e/--deploy-modeis deprecated in favor of-m/--master.This PR keeps the change scoped to the SeaTunnel engine task command generated for
seatunnel.sh.Brief change log
--masterfor the SeaTunnel engine task deploy mode argument.Verify this pull request
git diff --checkJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -am -Dtest=SeatunnelTaskTest,SeatunnelParametersTest -Dsurefire.failIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dspotless.skip=true -Danalyze.skip=true -Djacoco.skip=true -DskipDepCheck=true testJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -DskipTests -Djacoco.skip=true -DskipDepCheck=true spotless:checkPull Request Notice
This pull request does not contain incompatible changes.